Prettier error-page #836
Prettier error-page #836
Conversation
beshrislambouli
force-pushed
the
error-page
branch
from
373cc6d
to
e6c01af
Compare
| ) : ( | ||
| <span className="text-red-600 text-center block">An unknown error occurred.</span> | ||
| )} | ||
| <button |
There was a problem hiding this comment.
We have a custom Button component in components/elements that you can use for any buttons you create, it's pre styled.
There was a problem hiding this comment.
I think we can just use a div here instead of a button though (put the div inside the Link component)
| <span className="text-red-600 text-center block">An unknown error occurred.</span> | ||
| )} | ||
| <button | ||
| onClick={handleGoHome} |
There was a problem hiding this comment.
instead of using navigate we can use the React Router Link component https://reactrouter.com/en/main/components/link
It'll simplify the logic a bit, I think that navigate should be used for more complicated logic
|
also make sure to run |
| <PageTitle>Oops, something went wrong.</PageTitle> | ||
| <p> | ||
| <p className="text-center"> | ||
| Please reach out on Discord or to [email protected] with the |
There was a problem hiding this comment.
Let's replace this with whatever the standard way to link to an email address is! Maybe:
<a href="mailto:[email protected]?subject=play.battlecode.org%20Bug%20Report&body=This%20is%20the%20email%20body">[email protected]</a>
where the body is the error message and page name (or some other well-formatted embedding of the error information 😃)
closes #796